You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
65 lines
2.2 KiB
Markdown
65 lines
2.2 KiB
Markdown
10 years ago
|
# (Vague) Jasmine 2.0 Goals/(Guidelines)
|
||
|
|
|
||
|
|
1. No globals!
|
||
|
|
* jasmine library is entirely inside `jasmine` namespace
|
||
|
|
* globals required for backwards compatibility should be added in `boot.js` (EG, var describe = jasmine.getCurrentEnv().describe lives in boot.js)
|
||
|
|
1. Don't use properties as getters. Use methods.
|
||
|
|
* Properties aren't encapsulated -- can be mutated, unsafe.
|
||
|
|
1. Reporters get data objects (no methods).
|
||
|
|
* easier to refactor as needed
|
||
|
|
1. More unit tests - fewer nasty integration tests
|
||
|
|
|
||
|
|
## Remaining non-story-able work:
|
||
|
|
* Make a `TODO` list
|
||
|
|
|
||
|
|
### Hard
|
||
|
|
* Finish killing Globals
|
||
|
|
* Guidelines:
|
||
|
|
* New objects can have constructors on `jasmine`
|
||
|
|
* Top level functions can live on `jasmine`
|
||
|
|
* Top level (i.e., any `jasmine` property) should only be referenced inside the `Env` constructor
|
||
|
|
* should better allow any object to get jasmine code (Node-friendly)
|
||
|
|
* review everything in base.js
|
||
|
|
* Remove isA functions:
|
||
|
|
* isArray_ - used in matchers and spies
|
||
|
|
* isString_
|
||
|
|
* isDOMNode_
|
||
|
|
* isA_
|
||
|
|
* unimplementedMethod_, used by PrettyPrinter
|
||
|
|
* jasmine.util should be util closure inside of env or something
|
||
|
|
* argsToArray is used for Spies and matching (and can be replaced)
|
||
|
|
* inherit is only for PrettyPrinter now
|
||
|
|
* formatException is used only inside Env/spec
|
||
|
|
* htmlEscape is for messages in matchers - should this be HTML at all?
|
||
|
|
* Pretty printing
|
||
|
|
* move away from pretty printer and to a JSON.stringify implementation?
|
||
|
|
* jasmineToString vs. custom toString ?
|
||
|
|
|
||
|
|
### Easy
|
||
|
|
|
||
|
|
* unify params to ctors: options vs. attrs.
|
||
|
|
* This will be a lot of the TODOs, but clean up & simplify Env.js (is this a 2.1 task?)
|
||
|
|
|
||
|
|
### DONE
|
||
|
|
* Matchers improvements
|
||
|
|
* unit testable DONE
|
||
|
|
* better equality (from Underscore) DONE
|
||
|
|
* addCustomMatchers doesn't explode stack DONE
|
||
|
|
* refactor equals function so that it just loops & recurses over a list of fns (custom and built-in) - 2.1? (Tracker story)
|
||
|
|
* Spies
|
||
|
|
* break these out into their own tests/file DONE
|
||
|
|
|
||
|
|
|
||
|
|
## Other Topics
|
||
|
|
|
||
|
|
* Docs
|
||
|
|
* Docco has gone over well. Should we annotate all the sources and then have Pages be more complex, having tutorials and annotated source like Backbone? Are we small enough?
|
||
|
|
* Need examples for:
|
||
|
|
* How to build a Custom Matcher
|
||
|
|
* How to add a custom equality tester
|
||
|
|
|
||
|
|
|
||
|
|
|
||
|
|
|
||
|
|
|