Fix node system install script

node/.local/bin/install-node-system

@@ -1,5 +1,7 @@
 #!/usr/bin/env bash
 
+set -e
+
 # shellcheck disable=SC1090
 source "${XDG_DATA_HOME}/buddy-up/includes/node.sh"
 
@@ -7,14 +9,15 @@ PREFIX=${PREFIX:-/usr/local}
 DEST="${PREFIX}/apps/releases/node"
 CURRENT="${DEST}/current"
 
-extract_tarball "${URL}" "${DEST}/${VERSION}" "--strip-components 1" "sudo"
+extract_tarball "${URL}" "${DEST}/${VERSION}" "--strip-components 1" sudo
-set_current_link "${DEST}" "${VERSION}" "sudo"
+set_current_link "${DEST}" "${VERSION}" sudo
 
-for app in "${CURRENT}"/bin/*; do
+APPS=$(find "${CURRENT}"/bin -not -type d -exec basename {} ';')
-    set_symlink "${CURRENT}/bin/${app}" "${XDG_BIN_HOME}/${app}" sudo
+for app in ${APPS}; do
+    set_symlink "${CURRENT}/bin/${app}" "${PREFIX}/bin/${app}" sudo
 done
 
 set_symlink "${CURRENT}/include/node"          "${PREFIX}/include/node" sudo
-set_symlink "${CURRENT}/share/doc/node"        "${CURRENT}/share/doc/node" sudo
+set_symlink "${CURRENT}/share/doc/node"        "${PREFIX}/share/doc/node" sudo
-set_symlink "${CURRENT}/share/man/man1/node.1" "${CURRENT}/share/man/man1/node.1" sudo
+set_symlink "${CURRENT}/share/man/man1/node.1" "${PREFIX}/share/man/man1/node.1" sudo
-set_symlink "${CURRENT}/share/systemtap/tapset/node.stp" "${CURRENT}/share/systemtap/tapset/node.stp" sudo
+set_symlink "${CURRENT}/share/systemtap/tapset/node.stp" "${PREFIX}/share/systemtap/tapset/node.stp" sudo

node/.local/share/buddy-up/includes/node.sh

@@ -22,7 +22,7 @@ set_symlink () {
     sudo="$3"
     dest_dir=$(dirname "${dest}")
 
-    mkdir_if_missing "${dest_dir}"
+    mkdir_if_missing "${dest_dir}" "$sudo"
     pushd "${dest_dir}" > /dev/null || exit 1
     unlink_if_set "${dest}" "${sudo}"
     $sudo ln -s "$(relative_path "${dest_dir}" "${src}")" "$(basename "${dest}")"